Skip to content

Implement aggregation algorithm with recursive proof verification#2601

Merged
bkolad merged 4 commits intodevfrom
blaz/agg_proof5
Mar 20, 2026
Merged

Implement aggregation algorithm with recursive proof verification#2601
bkolad merged 4 commits intodevfrom
blaz/agg_proof5

Conversation

@bkolad
Copy link
Member

@bkolad bkolad commented Mar 17, 2026

Description

This PR introduces the following changes:

  1. Extracts the aggregation logic from main.rs into a dedicated aggregation.rs module, with a generic run_aggregation_program function for verifying inner proof chains and recursive outer proofs.

  2. Adds a build.rs step that precomputes the inner verifying key hash at compile time, removing it from the runtime witness.

  3. Renames CodeCommitment to OuterCodeCommitmentHash and vkey_hash to outer_vkey_hash throughout the codebase for improved clarity.

Note for reviewers: The substantive change is in aggregation.rs. The remaining changes are primarily renaming and script-related improvements, and are not relevant to the security of the outer circuit.

  • I have updated CHANGELOG.md with a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.
  • I have carefully reviewed all my Cargo.toml changes before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)

Linked Issues


Open with Devin

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.9%. Comparing base (f20563b) to head (0d5faa6).
⚠️ Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...interface/src/state_machine/zk/aggregated_proof.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...unner/src/processes/prover_service/parallel/mod.rs 100.0% <100.0%> (ø)
...er/src/processes/prover_service/parallel/prover.rs 92.0% <100.0%> (ø)
crates/module-system/sov-modules-api/src/lib.rs 96.2% <ø> (ø)
.../utils/sov-test-utils/src/rt_agnostic_blueprint.rs 73.8% <ø> (ø)
...interface/src/state_machine/zk/aggregated_proof.rs 0.0% <0.0%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bkolad bkolad changed the title WIP agg proof Title: Implement aggregation algorithm with recursive proof verification Mar 19, 2026
@bkolad bkolad marked this pull request as ready for review March 19, 2026 11:39
@bkolad bkolad changed the title Title: Implement aggregation algorithm with recursive proof verification Implement aggregation algorithm with recursive proof verification Mar 19, 2026
@bkolad bkolad marked this pull request as draft March 19, 2026 14:42
@bkolad bkolad marked this pull request as ready for review March 19, 2026 15:52
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

@bkolad bkolad merged commit 7c0c3a5 into dev Mar 20, 2026
23 of 24 checks passed
@bkolad bkolad deleted the blaz/agg_proof5 branch March 20, 2026 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants