Implement aggregation algorithm with recursive proof verification#2601
Merged
Implement aggregation algorithm with recursive proof verification#2601
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
bkolad
commented
Mar 19, 2026
bkolad
commented
Mar 19, 2026
bkolad
commented
Mar 19, 2026
ross-weir
reviewed
Mar 20, 2026
citizen-stig
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
Extracts the aggregation logic from
main.rs into a dedicatedaggregation.rsmodule, with a genericrun_aggregation_programfunction for verifying inner proof chains and recursive outer proofs.Adds a
build.rsstep that precomputes the inner verifying key hash at compile time, removing it from the runtime witness.Renames
CodeCommitmenttoOuterCodeCommitmentHashandvkey_hashtoouter_vkey_hashthroughout the codebase for improved clarity.Note for reviewers: The substantive change is in aggregation.rs. The remaining changes are primarily renaming and script-related improvements, and are not relevant to the security of the outer circuit.
I have updatedCHANGELOG.mdwith a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.Cargo.tomlchanges before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)Linked Issues