Remove yawol and kube-vip #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschoone
added
the
Container
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
8 times, most recently
from
b28f476 to
5780439
Compare
jschoone
changed the title
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
from
f610df5 to
3d34c07
Compare
1 task
Member
chess-knight
left a comment
chess-knight
left a comment
There was a problem hiding this comment.
Overall LGTM, just few suggestions:
- update docs
- remove yawol from openstack-csp-helper
providers/openstack/scs/cluster-class/templates/cluster-class.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks, docs have been updated |
chess-knight
approved these changes
Mar 10, 2025
According to https://github.com/SovereignCloudStack/minutes/blob/main/container/20250221.md yawol and kube-vip will be removed. Co-authored-by: Roman Hros <[email protected]> Signed-off-by: Jan Schoone <[email protected]>
…#210) Kubernetes versions come from https://swift.services.a.regiocloud.tech/swift/v1/AUTH_b182637428444b9aa302bb8d5a5a418c/openstack-k8s-capi-images/ OCCM and Cinder-CSI versions come from https://kubernetes.github.io/cloud-provider-openstack Signed-off-by: Jan Schoone <[email protected]>
refactor(cluster-addons): Update metrics-server values The values for the metrics server have changed and some are already outdated. This smaller version should to the same for this case. Signed-off-by: Jan Schoone <[email protected]>
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
from
3f9366a to
fbf6fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
According to
https://github.com/SovereignCloudStack/minutes/blob/main/container/20250221.md
yawol and kube-vip will be removed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please do not use "Squash and merge"
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: