Skip to content

Feat/scs2 rationalize descriptions #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garloff merged 3 commits into from
Sep 9, 2025
Merged

Feat/scs2 rationalize descriptions #236

garloff merged 3 commits into from
Sep 9, 2025

Conversation

@garloff
Copy link
Member

@garloff garloff commented Sep 9, 2025

Improve descriptions in ClusterClass scs2:

  • Avoid capitalizing first letter of our lowerCamelCase variables
  • Adjust default in description apiServerLoadBalancer to the true value. Improve description.
  • Improve wording w.r.t. flavors and rootdisks.
  • Rationalize longer description strings using YAML multiline syntax (|, |-, >-)

@garloff
Fix clusterclass var descriptions capitalization and defaults.
6869a9e 
Also, rationalize long descriptions to use multi-line yaml strings.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Add missing {} on empty dict.
852e7e6 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Better description of apiServerLoadBalancer.
facc510 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff requested a review from jschoone September 9, 2025 10:02
@garloff garloff self-assigned this Sep 9, 2025
@garloff garloff merged commit 36436d1 into scs2_cluster_stacks Sep 9, 2025
6 checks passed
@garloff garloff deleted the feat/scs2-rationalize-descriptions branch September 9, 2025 13:12
jschoone added a commit that referenced this pull request Sep 25, 2025
@jschoone
feat(cluster-stacks): Add new Cluster Stacks scs2
7ffad1d 
Signed-off-by: Jan Schoone <[email protected]>

Feat/scs2 rationalize descriptions (#236)

* Fix clusterclass var descriptions capitalization and defaults.
   Also, rationalize long descriptions to use multi-line yaml strings.
* Add missing {} on empty dict.
* Better description of apiServerLoadBalancer.

Signed-off-by: Kurt Garloff <[email protected]>
jschoone added a commit that referenced this pull request Sep 25, 2025
@jschoone
feat(cluster-stacks): Add new Cluster Stacks scs2
04fc39b 
Signed-off-by: Jan Schoone <[email protected]>

Feat/scs2 rationalize descriptions (#236)

* Fix clusterclass var descriptions capitalization and defaults.
   Also, rationalize long descriptions to use multi-line yaml strings.
* Add missing {} on empty dict.
* Better description of apiServerLoadBalancer.

Signed-off-by: Kurt Garloff <[email protected]>
garloff pushed a commit that referenced this pull request Sep 25, 2025
@jschoone
feat(cluster-stacks): Add new Cluster Stacks scs2 (#232)
f5f9a42 
Feat/scs2 rationalize descriptions (#236)

* Fix clusterclass var descriptions capitalization and defaults.
   Also, rationalize long descriptions to use multi-line yaml strings.
* Add missing {} on empty dict.
* Better description of apiServerLoadBalancer.

Signed-off-by: Kurt Garloff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jschoone jschoone Awaiting requested review from jschoone

Assignees

@garloff garloff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garloff