Skip to content

Conversation

@jschoone
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Jan Schoone <[email protected]>
@jschoone jschoone self-assigned this Nov 28, 2024
@jschoone jschoone requested review from okautz and removed request for okautz November 28, 2024 16:41
Signed-off-by: Jan Schoone <[email protected]>
@garloff garloff removed the size/XS label Feb 10, 2025
@cluster-stack-bot cluster-stack-bot bot added the size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. label Feb 26, 2025
@cluster-stack-bot cluster-stack-bot bot added size/S Denotes a PR that changes 20-50 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. labels Feb 26, 2025
@jschoone jschoone marked this pull request as draft February 28, 2025 09:07
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation and go 1.21.6 -> 1.22. Good.

@garloff
Copy link
Member

garloff commented Dec 17, 2025

Any reason this is marked as draft? Looks like a no-brainer to me.

@garloff garloff marked this pull request as ready for review December 17, 2025 13:41
@garloff garloff merged commit cdbcc97 into main Dec 17, 2025
6 checks passed
@garloff garloff deleted the update_go branch December 17, 2025 13:41
schmidax pushed a commit to schmidax/csctl that referenced this pull request Dec 19, 2025
* chore(builder): update go version
* Update Dockerfile
* chore: update base image
* chore(builder): update go version
* Update Dockerfile
* chore: update base image
* chore(builder): update go version
* chore: update base image

Signed-off-by: Jan Schoone <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Co-authored-by: Jan Schoone <[email protected]>
Co-authored-by: Kurt Garloff <[email protected]>
Signed-off-by: Axel Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 20-50 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants