improvements #13
Merged
improvements #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scoopex
commented
Apr 23, 2025
scoopex
commented
- be more tolerant references to cloud.yaml entries
- set mtu automatically if set to 0
- use directly the specified path if a file is specified
- be more tolerant references to cloud.yaml entries - set mtu automatically if set to 0 - use directly the specified path if a file is specified Signed-off-by: Marc Schöchlin <[email protected]>
scoopex
force-pushed
the
automatic_mtu_sizes
branch
from
9179bb7 to
4af120d
Compare
Signed-off-by: Marc Schöchlin <[email protected]>
scoopex
force-pushed
the
automatic_mtu_sizes
branch
from
0e265ec to
cf22a46
Compare
garloff
approved these changes
Apr 24, 2025
Member
garloff
left a comment
garloff
left a comment
There was a problem hiding this comment.
No serious review, just a quick check not seeing anything evil.
If you want to develop this without reviews, we should set up the repo to allow you to override branch protection...
| try: | ||
| LOGGER.info(f"Reading {Config._file}") | ||
| with open(str(Config._file), 'r') as file_fd: | ||
| with open(str(Config._file), "r") as file_fd: |
Contributor
Author
There was a problem hiding this comment.
Yes, that would be nice. I prefer reviews but if there is nobody how can do them, its better to have the possibility to skip them.
scoopex
added a commit
that referenced
this pull request
May 14, 2025
* improvements - be more tolerant references to cloud.yaml entries - set mtu automatically if set to 0 - use directly the specified path if a file is specified Signed-off-by: Marc Schöchlin <[email protected]> * satisfy mypy and linting Signed-off-by: Marc Schöchlin <[email protected]> --------- Signed-off-by: Marc Schöchlin <[email protected]> Co-authored-by: Marc Schöchlin <[email protected]> Co-authored-by: Kurt Garloff <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]>
scoopex
added a commit
that referenced
this pull request
May 14, 2025
* Health mon profile (#11) * add a health mon profile --- Signed-off-by: Marc Schöchlin <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> Co-authored-by: Marc Schöchlin <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> * Bump jinja2 from 3.1.4 to 3.1.6 in the pip group across 1 directory (#12) Bumps the pip group with 1 update in the / directory: [jinja2](https://github.com/pallets/jinja). Updates `jinja2` from 3.1.4 to 3.1.6 - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.4...3.1.6) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production dependency-group: pip ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marc Schöchlin <[email protected]> * improvements (#13) * improvements - be more tolerant references to cloud.yaml entries - set mtu automatically if set to 0 - use directly the specified path if a file is specified Signed-off-by: Marc Schöchlin <[email protected]> * satisfy mypy and linting Signed-off-by: Marc Schöchlin <[email protected]> --------- Signed-off-by: Marc Schöchlin <[email protected]> Co-authored-by: Marc Schöchlin <[email protected]> Co-authored-by: Kurt Garloff <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> * minor-improvement (#14) Signed-off-by: Marc Schöchlin <[email protected]> Co-authored-by: Marc Schöchlin <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> * Update help output (#15) Signed-off-by: Marc Schöchlin <[email protected]> Co-authored-by: Marc Schöchlin <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> * remove outdated example ssh keys Signed-off-by: Marc Schöchlin <[email protected]> * check if flavor or images exsists Signed-off-by: Marc Schöchlin <[email protected]> * feature: handle existing clouds.yaml merge the configuration of generated projects to a existing clouds.yaml and make a backup Signed-off-by: Marc Schöchlin <[email protected]> * Fix imports in module entry point (#16) Signed-off-by: Max Harmathy <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> * fix typing Signed-off-by: Marc Schöchlin <[email protected]> --------- Signed-off-by: Marc Schöchlin <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Max Harmathy <[email protected]> Signed-off-by: Marc Schöchlin <[email protected]> Co-authored-by: Marc Schöchlin <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kurt Garloff <[email protected]> Co-authored-by: Max Harmathy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.