Skip to content

Conversation

@matofeder
Copy link
Member

@matofeder matofeder commented Nov 12, 2024

…ith NetBox as a central source

Signed-off-by: Matej Feder <[email protected]>
Signed-off-by: Matej Feder <[email protected]>
Copy link

@OgarOgarovic OgarOgarovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scoopex
Copy link
Contributor

scoopex commented Nov 15, 2024

I merged the current state to the "staging" branch, to have a preview at https://staging.scs.community/

@matofeder
Copy link
Member Author

matofeder commented Nov 18, 2024

I merged the current state to the "staging" branch, to have a preview at https://staging.scs.community/

I added some minor fixes add902b and merged the current version of blog to the staging branch again.

@garloff
Copy link
Member

garloff commented Nov 18, 2024

Any reason not to merge this @scoopex , @OgarOgarovic ?

@scoopex
Copy link
Contributor

scoopex commented Nov 18, 2024

Any reason not to merge this @scoopex , @OgarOgarovic ?

Not from my view.

@scoopex
Copy link
Contributor

scoopex commented Nov 20, 2024

@maxwolfs : I wanted to wait for the preview at https://staging.scs.community/website/de/news/ but it does not appear there (the blogpost ist merged to staging). Any idea why that is the case?

@maxwolfs
Copy link
Member

@maxwolfs : I wanted to wait for the preview at https://staging.scs.community/website/de/news/ but it does not appear there (the blogpost ist merged to staging). Any idea why that is the case?

Maybe the staging branch has been deleted and another branch has been merged to staging? I have just done it again with this branch to staging. Should work once completed.

@maxwolfs
Copy link
Member

The build process creates the html page out of it (see here), but it seems that the content of gh-pages-staging does not get properly deployed on the server? At least that would be my guess.

Copy link
Contributor

@scoopex scoopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scoopex scoopex merged commit ab58692 into main Nov 20, 2024
7 checks passed
@scoopex scoopex deleted the add_sonic_netbox_blog branch November 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants