Conversation
rnestler
force-pushed
the
add-pull-request-template
branch
from
9ff95fe to
150dcb7
Compare
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| If you're adding a new endpoint consider the following | |||
| * [ ] Note that the list is sorted alphabetically | |||
| * [ ] Verify that your endpoint is valid using <https://validator.spaceapi.io/ui> | |||
There was a problem hiding this comment.
I think a lot of people don't know about the validator and this is a good moment to make them aware of it.
There was a problem hiding this comment.
Generally a good idea, but if we want to do this as a checklist, I'd formulate it as "This is completed", e.g. The endpoint is valid according to <https://validator.spaceapi.io/ui>, The new entry is at the correct (alphabetically sorted) line.
There was a problem hiding this comment.
@rnestler is this something we can look it soon? We've had multiple directory PRs since, and in (close to) all of them we had to refer people to the validator.
There was a problem hiding this comment.
Fixed it. I'd encourage you to use the "Add a suggestion" feature if you want to change small wording things, such that one can just apply the change and then merge it.
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| If you're adding a new endpoint consider the following | |||
| * [ ] Note that the list is sorted alphabetically | |||
| * [ ] Verify that your endpoint is valid using <https://validator.spaceapi.io/ui> | |||
There was a problem hiding this comment.
Generally a good idea, but if we want to do this as a checklist, I'd formulate it as "This is completed", e.g. The endpoint is valid according to <https://validator.spaceapi.io/ui>, The new entry is at the correct (alphabetically sorted) line.
rnestler
force-pushed
the
add-pull-request-template
branch
from
150dcb7 to
e6ff4c9
Compare
2 participants
No description provided.