Merged
Conversation
rnestler
reviewed
Feb 27, 2025
Member
rnestler
left a comment
rnestler
left a comment
There was a problem hiding this comment.
Thanks! A are a few issues (See https://validator.spaceapi.io/ui/?url=https://devhack.net/spaceapi.json) with your endpoint:
- CORS headers seem incorrect
- The version you support is very old. Consider supporting v14 and v15 instead of v0.13 see https://spaceapi.io/
Contributor
Author
this is because I'm using the homeassistant spaceapi integration, there's an open ticket for that but it's mostly out of my hands: home-assistant/core#109158 |
Contributor
Author
|
fixed cors, though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.