-
Notifications
You must be signed in to change notification settings - Fork 1
Can Monitoring of ECUs #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raffael0
wants to merge
14
commits into
main
Choose a base branch
from
feature/can_monitoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t exist (It now creates it)
…e from the executable. With this one can test the LLServer without an influxdb running
- Added a new ECUIEmulator.py script with which one can send json commands to the llserver
Resolved an issue where sensors defined in `globals/ranges` but not set in any action were still included in the CSV log file header. Since no values were provided for these ranges, data entries were ignored, leading to misaligned CSV rows. Changed the behavior to ignore sensor ranges set in an action if they are not set in `globals/ranges`
…nd removed the requirement of python3.11 in the CMakeLists.txt
miDeb
approved these changes
Apr 13, 2025
Member
miDeb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a more or less superficial look, but looks good to me.
3869575 to
46269c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works in conjunction with PRs in can_houbolt, STRHAL and firmware_liquids.
It adds a new channel to the ECUs which monitors the state of their CAN chips.
On the LLServer the following features were implemented:
This PR is based on #4 and should be merged after that one