Conversation
Contributor
Author
|
just rerunning CI |
Contributor
Author
|
oh it requires approval 🤦🏻♀️ |
Owner
The pipeline is currently broken for Windows. It need to be addressed, but it is not the problem of the current PR. |
|
Is there an ETA for the next release with this fix applied? |
Owner
I’ll try to make the release this week, but I can’t promise anything. |
|
@SpaiR any updates? TGStation is kinda waiting on you to release the next SDMM update before they work on a fix for a major issue preventing code from building on BYOND versions 516.1670+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the dependencies of
sdmmparser, including updating SpacemanDMM to the officialsuite-1.11release, and runningcargo updatefor it overall.Updating SDMM allows for it to parse projects with const
alist(),icon_w/icon_z, and other 516 features - see a before/after of this working below.I've also made the Taskfile use
--lockedforcargo build, so that the cargo lockfile actually matters.Fixes #370
Fixes #353
Fixes #375
Before
sdmm-alist-broken.mp4
After
sdmm-alist-working.mp4
Type of change