Support mixed CSR/CSC operations #43

BenBrock · 2025-03-06T21:23:18Z

This PR adds support for mixed CSR/CSC operations. This is done in three parts:

In the reference implementation, I added algorithms for outer product, inner product, and "scattered Gustavson's." This handles all combinations of CSC and CSR for both inputs and outputs.
Added tests for mixed CSR/CSC operations.
Extended MKL/ArmPL backends to work on both CSR and CSC matrices.

Co-authored-by: Spencer Patty <[email protected]>

of inputs.

include/spblas/algorithms/detail/spgemm/spgemm_innerproduct.hpp

include/spblas/algorithms/detail/spgemm/spgemm_outerproduct.hpp

include/spblas/vendor/armpl/detail/export_matrix_handle.hpp

include/spblas/vendor/onemkl_sycl/spgemm_impl.hpp

test/gtest/spgemm_csr_csc.cpp

include/spblas/algorithms/detail/sparse_dot_product.hpp

spencerpatty

this is a great first implementation of all the spgemm algorithms with csr/csc inputs and outputs. Approved for merge. I did add a few suggestions for future improvements that could be used to reduce memory footprint of workspaces, thereby improving performance since we are generally memory bound here.

first phase of inner product.

spencerpatty

new changes look good. Approved for merge again.

Implementations of hash_accumulator and sparse_intersection are good starting places and could be optimized further in subsequent actions.

BenBrock and others added 21 commits February 27, 2025 15:13

Implement csc_view, implement transposed.

de12da2

Fix tests---should be recovered from force push.

ae5af30

Add CSC SpMV test.

6632825

Make scaled_view work with csc_view.

3750a1e

Update MKL to support CSC.

e1f2cd2

Merge branch 'main' into dev/brock/implement-transposed

3fde64c

Suppose operations with CSC in ArmPL.

1f2be4a

Update include/spblas/vendor/onemkl_sycl/detail/create_matrix_handle.hpp

dd7bfb4

Co-authored-by: Spencer Patty <[email protected]>

Update examples/spmm_csc.cpp

907539b

Co-authored-by: Spencer Patty <[email protected]>

Fix formatting

273ae73

Add CSC View SpMV BScaled test.

cf16b4c

First stab at implementing CSR x CSC -> CSR.

7a8cb29

Merge branch 'main' into dev/brock/mixed-csr-csc

53a59c0

Support mixed CSR/CSC in MKL.

543ed24

Implement dot product with accumulator to avoid having to sort indices

91c017e

of inputs.

Bugfix: wrong dimension.

a83b0a0

Implement outer product SpGEMM.

dae6de6

Remove unnecessary transposed inner product implementations.

b13e998

Implement "scattered Gustavson's," add testing, ensure works in ArmPL.

4a2e3a1

Commit missing files

3a77817

Enable CSC output in MKL.

0ca3447

BenBrock marked this pull request as ready for review March 7, 2025 02:02

BenBrock requested review from spencerpatty and upsj March 7, 2025 02:02