Skip to content

Fix sparse vectors eadd on CPU #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkutuev merged 1 commit into from
Apr 9, 2025
Merged

Fix sparse vectors eadd on CPU #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/cpu/cpu_v_eadd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ namespace spla {
const CpuCooVec<T>* p_v = v->template get<CpuCooVec<T>>();
const auto& function = op->function;

const T u_fill_value = u->get_fill_value();
const T v_fill_value = v->get_fill_value();

assert(p_r->Ax.empty());

const auto u_count = p_u->values;
Expand All @@ -96,11 +99,11 @@ namespace spla {
while (u_iter < u_count && v_iter < v_count) {
if (p_u->Ai[u_iter] < p_v->Ai[v_iter]) {
p_r->Ai.push_back(p_u->Ai[u_iter]);
p_r->Ax.push_back(p_u->Ax[u_iter]);
p_r->Ax.push_back(function(p_u->Ax[u_iter], v_fill_value));
u_iter += 1;
} else if (p_v->Ai[v_iter] < p_u->Ai[u_iter]) {
p_r->Ai.push_back(p_v->Ai[v_iter]);
p_r->Ax.push_back(p_v->Ax[v_iter]);
p_r->Ax.push_back(function(u_fill_value, p_v->Ax[v_iter]));
v_iter += 1;
} else {
p_r->Ai.push_back(p_u->Ai[u_iter]);
Expand All @@ -112,13 +115,13 @@ namespace spla {
}
while (u_iter < u_count) {
p_r->Ai.push_back(p_u->Ai[u_iter]);
p_r->Ax.push_back(p_u->Ax[u_iter]);
p_r->Ax.push_back(function(p_u->Ax[u_iter], v_fill_value));
u_iter += 1;
p_r->values += 1;
}
while (v_iter < v_count) {
p_r->Ai.push_back(p_v->Ai[v_iter]);
p_r->Ax.push_back(p_v->Ax[v_iter]);
p_r->Ax.push_back(function(u_fill_value, p_v->Ax[v_iter]));
v_iter += 1;
p_r->values += 1;
}
Expand Down
Loading