-
Notifications
You must be signed in to change notification settings - Fork 300
feat: update db pooling to handle iam rds auth, move DatabaseConfiguration to DAWGS - BI-1306 #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mamundsen-specter
wants to merge
18
commits into
main
Choose a base branch
from
bi-1348-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+206
−103
Open
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d2a133f
update db pooling to handle iam rds auth v8.2.0
mamundsen-specter 7e47f1b
update cname handling
mamundsen-specter f8db22a
merging with main
mamundsen-specter 008a29a
add iam_auth config option
mamundsen-specter 4660710
merge with main v8.5.0
mamundsen-specter 580f0c7
merge with main v8.5.2
mamundsen-specter 60eb878
move PostgreSQLConnectionString() to dawgs
mamundsen-specter 9ad1186
update dawgs-harness and NewDefaultConfiguration()
mamundsen-specter 6b8f29d
fix neo4j dawgs-harness test
mamundsen-specter ed901a3
merge with main
mamundsen-specter 5fe2a68
update cachestats
mamundsen-specter 1cd17b3
merge with main again
mamundsen-specter 5b9f5e5
update target DAWGs commit
mamundsen-specter 09aa07c
update OpenDatabase and InitializeService to use DatabaseConfiguratio…
mamundsen-specter 71fdb81
merge with main
mamundsen-specter 41bc8da
merge with main
mamundsen-specter a656e34
fixup additional tests
mamundsen-specter 4064318
bump dawgs branch
mamundsen-specter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Error from
NewDefaultConfiguration()is silently discarded.fmt.Errorfcreates an error value but doesn't do anything with it — the program continues with a zero-valuecfgon failure. This should usefatalf(or similar) to halt execution.Proposed fix
cfg, err := config.NewDefaultConfiguration() if err != nil { - fmt.Errorf("failed to create default configuration: %w", err) + fatalf("failed to create default configuration: %v", err) }🤖 Prompt for AI Agents