Skip to content

chore: Improving click and select actions in PZ certification BED-7356 #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucasParraF wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −7
Open

chore: Improving click and select actions in PZ certification BED-7356 #2523

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dbfe388
chore: manage item selection when using checkbox
LucasParraF Mar 19, 2026
cffaf03
augment: manage item selection when using checkbox
LucasParraF Mar 19, 2026
5f976fd
Merge branch 'BED-7356-Improving-click-and-select-actions-in-PZ-certi…
LucasParraF Mar 19, 2026
04d62b7
Merge remote-tracking branch 'origin/main' into BED-7356-Improving-cl…
LucasParraF Mar 20, 2026
55082e0
chore: cleanup
LucasParraF Mar 20, 2026
1a79567
Merge remote-tracking branch 'origin/main' into BED-7356-Improving-cl…
LucasParraF Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/javascript/doodle-ui/src/components/DataTable/DataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,18 +201,21 @@ const DataTable = <TData, TValue>(props: DataTableProps<TData, TValue>) => {
const handleRowClick = useCallback(
(row: Row<TData>) => {
if (typeof onRowClick === 'function') {
const isAlreadySelected = table.getState().rowSelection[row.id];

if (isAlreadySelected) {
table.setRowSelection({});
} else {
table.setRowSelection({ [row.id]: true });
// When selectedRow is provided the parent controls selection.
if (selectedRow === undefined) {
const isAlreadySelected = table.getState().rowSelection[row.id];
Comment on lines +204 to +206
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use one consistent controlled/uncontrolled predicate.

This branch uses selectedRow === undefined, but the state-sync effect uses truthy/falsy checks. That mismatch can behave differently for falsy-but-defined IDs and lead to unexpected selection clearing.

Proposed alignment 
-    useEffect(() => {
-        if (!selectedRow && table.getIsSomeRowsSelected()) {
+    useEffect(() => {
+        if (selectedRow === undefined && table.getIsSomeRowsSelected()) {
             table.setRowSelection({});
         }
 
-        if (selectedRow && !table.getState().rowSelection[selectedRow]) {
+        if (selectedRow !== undefined && !table.getState().rowSelection[selectedRow]) {
             table.setRowSelection({ [selectedRow]: true });
         }
     }, [selectedRow, table]);
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/javascript/doodle-ui/src/components/DataTable/DataTable.tsx` around
lines 204 - 206, The selection-control predicate is inconsistent: one branch
checks selectedRow === undefined while the state-sync effect uses truthy/falsy
checks, which breaks when IDs are falsy (e.g., 0 or ""). Update the state-sync
effect to use the same explicit undefined check (selectedRow === undefined) or
change both places to use a single canonical predicate (e.g., selectedRow ===
undefined for uncontrolled) so selection clearing is consistent; locate the
logic around selectedRow, the branch using
table.getState().rowSelection[row.id], and the state-sync effect and make their
checks identical.


if (isAlreadySelected) {
table.setRowSelection({});
} else {
table.setRowSelection({ [row.id]: true });
}
}

onRowClick(row?.original);
}
},
[onRowClick, table]
[onRowClick, selectedRow, table]
);

const { className: tableClassName, heightContainerClassName, ...restTableProps } = TableProps || {};
Expand Down
Loading