Skip to content

Commit cade05f

Browse files
authored
Remove commands to set VSCode as git editor (#65)
The commands were failing, causing the devcontainer to fail to start. The git editor is better set in the user's [dotfiles][1] ([example][2]) [1]: https://docs.github.com/en/github/developing-online-with-codespaces/personalizing-codespaces-for-your-account [2]: https://github.com/johnboyes/dotfiles/blob/master/.gitconfig
1 parent c8ac0ea commit cade05f

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

.devcontainer/Dockerfile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ ARG VARIANT=buster
66
FROM mcr.microsoft.com/vscode/devcontainers/base:${VARIANT}
77

88

9-
ARG GIT_EDITOR_SCRIPT_SOURCE="https://raw.githubusercontent.com/microsoft/vscode-dev-containers/master/containers/codespaces-linux/.devcontainer/git-ed.sh"
109
ARG SHELLCHECK_VERSION="v0.7.1"
1110
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1211
RUN apt-get update \
@@ -18,15 +17,8 @@ RUN apt-get update \
1817
&& mkdir -p /tmp/shellcheck \
1918
&& wget -qO- "https://github.com/koalaman/shellcheck/releases/download/${SHELLCHECK_VERSION}/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar -xJv -C /tmp/shellcheck/ \
2019
&& install -m 755 /tmp/shellcheck/shellcheck-${SHELLCHECK_VERSION}/shellcheck /usr/local/bin/shellcheck \
21-
# Configure VSCode as the default editor for git commits
22-
# Adapted from https://github.com/microsoft/vscode-dev-containers/blob/master/containers/codespaces-linux/.devcontainer/Dockerfile
23-
&& mkdir -p /tmp/git-ed \
24-
&& wget -qO /tmp/git-ed/git-ed.sh ${GIT_EDITOR_SCRIPT_SOURCE} \
25-
&& install -m 755 /tmp/git-ed/git-ed.sh /usr/local/bin/git-ed.sh \
26-
&& git config --global core.editor "/usr/local/bin/git-ed.sh" \
2720
# Clean up
2821
&& apt-get autoremove -y \
2922
&& apt-get clean -y \
3023
&& rm -rf /var/lib/apt/lists/* \
3124
&& rm -rf /tmp/shellcheck \
32-
&& rm -rf /tmp/git-ed

0 commit comments

Comments
 (0)