-
Notifications
You must be signed in to change notification settings - Fork 1
Update examples and instructions in README #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@smjoshiatglobus thanks for this PR! There is a check on the commit message style which is currently failing, so would be very grateful if you can amend the commit messages to conform to this style please, as per the contributing guide? |
55c87bb to
295e659
Compare
Thank you and sorry for not know about the commit message style guide. This is very helpful! I have revised the last commit message (twice). Please review and let me know if any changes are needed. |
Thanks. One of the commit messages is ok now, but the other one ("updated example, lint fixes") needs to be amended too, please. |
I was baffled by the same! I found out how to amend last commit message and did it. Then I realized that the check was still failing and it was probably due to subject line of the PR, which probably becomes a commit message when merging. I have fixed it now and this check seems to have passed: https://github.com/SpectoLabs/hoverfly-github-action/actions/runs/13914168231/job/38934192603?pr=80. Is that good enough or do I need to go back and figure out how to amend older commit messages? |
Nice work @smjoshiatglobus, the commit message check is passing now 🎉 The only thing preventing me from merging this now is that there are other required checks which are not running for some reason. This may be because this repo has been dormant for so long, and/or it may be because this is the first PR submitted from a fork. It's difficult for me to diagnose because I don't have admin access on this |
|
@smjoshiatglobus being able to amend earlier Git commit messages is a handy skill to have by the way - this is a useful guide on how to do so, FYI: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History |
|
@smjoshiatglobus good news: if you can please rebase this pull request against the |
The examples and instructions in the README.md file point to a repository in GitHub's "agilepathway" account. The repository has moved to the "SpectoLabs" account now. Therefore, instructions, examples, and links are updated in this commit.
295e659 to
c237736
Compare
|
Thanks @smjoshiatglobus, we are almost there. I've asked @marcoioco to make the final tweaks to the required status checks and then we should be good to go. Thanks again for this PR and being patient with all the admin involved to get it merged. You've paved the way for any future PRs from external contributors like yourself to this repo to be seamless from now on 👍🏻 |
Thank you for managing these repositories, showing me the path to good Git commit messages, and your kind words! |
agilepathwaywithSpectoLabs#64 and issue Help find GitHub action #79agilepathwaywithSpectoLabsmarkdownlintextension of VS Code