Skip to content

Conversation

JoeyBF
Copy link
Collaborator

@JoeyBF JoeyBF commented Jul 29, 2025

This PR implements 3 related changes:

  • We remove the SteenrodAlgebraT traits (resolves Removing SteenrodAlgebraT traits #77)
  • We replace the manual dispatch with macros with enum_dispatch. We used to do that, but it was reverted in ff7d720, because enum_dispatch was causing issues. The current version does not have those issues anymore.
  • We remove polynomial algebras, which were both completely untested and unused, and tend to cause problems with conflicting implementations, particularly impl<A: PolynomialAlgebra> Algebra for A.

@JoeyBF JoeyBF mentioned this pull request Jul 29, 2025
@JoeyBF JoeyBF requested a review from Copilot July 31, 2025 13:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the algebra crate by simplifying the trait hierarchy and removing unused code. The changes modernize the codebase by replacing manual dispatch with enum_dispatch macros and eliminating untested functionality.

  • Removes SteenrodAlgebraT traits that were originally used for Python bindings
  • Replaces manual dispatch macros with enum_dispatch for better performance and code generation
  • Removes polynomial algebras which were completely untested and unused

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
steenrod_algebra.rs Removes trait implementations and manual dispatch, adds enum_dispatch attribute
polynomial_algebra.rs Complete removal of polynomial algebra implementation
pair_algebra.rs Adds comment explaining why enum_dispatch cannot be used
mod.rs Updates exports to remove deleted traits and polynomial algebra types
milnor_algebra.rs Removes MilnorAlgebraT trait
bialgebra_trait.rs Adds enum_dispatch attribute
algebra_trait.rs Adds enum_dispatch attributes and removes manual dispatch macro
adem_algebra.rs Removes AdemAlgebraT trait
Cargo.toml Adds enum_dispatch dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing SteenrodAlgebraT traits

1 participant