Add @param markers for all other model components #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@component works the same as @param but automatically adds an attribute :component based on the fieldname
Applies @parameterized to all the ShallowWater, PrimitiveDry, and PrimitiveDry models as well as all subcomponents
bgroenks96
added
user interface 🎹
|
@milankl I will try to look at this again next week, but it would be good if you could provide feedback first? |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies
@parameterizedto all the ShallowWater, PrimitiveDry, and PrimitiveDry models as well as all subcomponents.Also introduces the
@componentmarker which functions the same as@parambut automatically adds an attribute:componentmatching the field name. This makes it easier to declare parameterized subcomponents of a model.Needs tests and docs. @milankl please review the choices of which fields to make parameters and also bounds!
Resolves #760