Skip to content

Conversation

pierluigividale
Copy link
Collaborator

@pierluigividale pierluigividale commented Aug 8, 2025

  • Changes a few minor things for the land surface
  • Makes the LandBucketTemperature, LandBucketMoisture defaults for land model
  • the SlabOcean for ocean models
  • and ThermodynamicSeaIce default for sea ice model

pierluigividale and others added 3 commits August 8, 2025 15:30
Change soil thickness layers definition to enable more variability on land.
Changed IC for soil moisture and renamed runoff_fraction to infiltration_fraction
@milankl milankl changed the title Plv/landgeometry Make dynamic Land/Ocean/SeaIce models the default Aug 8, 2025
@milankl milankl added new defaults 🆕 Will change the defaults model components or their parameters. ocean 🌊 Water, water! land 🌍 A whole new woooorld! sea ice 🧊 Ice, ice, baby! labels Aug 8, 2025
@milankl milankl marked this pull request as draft August 12, 2025 12:20
@milankl
Copy link
Member

milankl commented Aug 12, 2025

I want to merge #814 into here first well at least #814 needs to be in main first

@milankl
Copy link
Member

milankl commented Aug 13, 2025

With #814 merged rerunning the tests here now. I also want to check for CI time. If CI takes too long it gets annoying to wait and so we have to "clean up" the tests by checking which take long and how we can test for the same things in shorter time. Most of what CI is spending time on is compile time so unfortunately that gets really tricky ... 🙈 but we aim for check to be completed in 15min. In contrast, 30min is already ... 😴

@milankl
Copy link
Member

milankl commented Aug 13, 2025

https://speedyweather.github.io/SpeedyWeatherDocumentation/previews/PR816

We should also check the documentation now as many things now run ocean, land and sea ice by default!

@milankl
Copy link
Member

milankl commented Aug 13, 2025

@maximilian-gelbrecht do you understand why Enzyme fails here?

@pierluigividale
Copy link
Collaborator Author

With #814 merged rerunning the tests here now. I also want to check for CI time. If CI takes too long it gets annoying to wait and so we have to "clean up" the tests by checking which take long and how we can test for the same things in shorter time. Most of what CI is spending time on is compile time so unfortunately that gets really tricky ... 🙈 but we aim for check to be completed in 15min. In contrast, 30min is already ... 😴

The worst of this is, the new generation of students shall never fully appreciate how such expectations are infuriatingly hilarious, and what it should have been all along.

@pierluigividale
Copy link
Collaborator Author

Right, I have checked the documentation under Main and all looks as we set it in the branch, but there are a few inconsistencies with the different sections of the documentation, e.g. on what the ocean is under examples versus what it is under model dynamics/physics definitions. I think that we need to take a little time to think about it and come up with a strategy, also for the future, as I continue to want to add a (terrestrial) snow module.

@milankl milankl marked this pull request as ready for review August 18, 2025 07:38
@milankl
Copy link
Member

milankl commented Aug 18, 2025

@pierluigividale is there anything you still want to change to have new default within the land model?

@pierluigividale
Copy link
Collaborator Author

I am happy with the current setup.

@pierluigividale pierluigividale merged commit 2085fa1 into main Aug 18, 2025
7 of 8 checks passed
milankl referenced this pull request Sep 12, 2025
* Bump version from 0.16.0 to 0.17.0

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
land 🌍 A whole new woooorld! new defaults 🆕 Will change the defaults model components or their parameters. ocean 🌊 Water, water! sea ice 🧊 Ice, ice, baby!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants