-
Notifications
You must be signed in to change notification settings - Fork 45
Make dynamic Land/Ocean/SeaIce models the default #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change soil thickness layers definition to enable more variability on land.
Changed IC for soil moisture and renamed runoff_fraction to infiltration_fraction
With #814 merged rerunning the tests here now. I also want to check for CI time. If CI takes too long it gets annoying to wait and so we have to "clean up" the tests by checking which take long and how we can test for the same things in shorter time. Most of what CI is spending time on is compile time so unfortunately that gets really tricky ... 🙈 but we aim for check to be completed in 15min. In contrast, 30min is already ... 😴 |
https://speedyweather.github.io/SpeedyWeatherDocumentation/previews/PR816 We should also check the documentation now as many things now run ocean, land and sea ice by default! |
@maximilian-gelbrecht do you understand why Enzyme fails here? |
The worst of this is, the new generation of students shall never fully appreciate how such expectations are infuriatingly hilarious, and what it should have been all along. |
Right, I have checked the documentation under Main and all looks as we set it in the branch, but there are a few inconsistencies with the different sections of the documentation, e.g. on what the ocean is under examples versus what it is under model dynamics/physics definitions. I think that we need to take a little time to think about it and come up with a strategy, also for the future, as I continue to want to add a (terrestrial) snow module. |
@pierluigividale is there anything you still want to change to have new default within the land model? |
I am happy with the current setup. |
* Bump version from 0.16.0 to 0.17.0 * update changelog
LandBucketTemperature
,LandBucketMoisture
defaults for land modelSlabOcean
for ocean modelsThermodynamicSeaIce
default for sea ice model