This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Add 'psychic' to skills as to not overload 'source'#51
Open
DroneEnthusiast wants to merge 1 commit intoSpice-King:masterfrom
Open
Add 'psychic' to skills as to not overload 'source'#51DroneEnthusiast wants to merge 1 commit intoSpice-King:masterfrom
DroneEnthusiast wants to merge 1 commit intoSpice-King:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a starting point for generalizing skill Items. I think the 'source' field is a great idea but overloading it to also indicate that a skill is psychic limits its usefulness going forward. For instance a custom psychic skill with a source other than "Revised" could not be added without a loss of data. By adding another field for psychic skills we also no longer have to string compare against 'source' to calculate effort.
I noticed the migration that had been written to change from "psychic" to "Psionic." This commit labels the skills "Psychic." This is based on a search of the core book. It is definitely inconsistent though! There are 45 instances of "psychic skill" and 6 instances of "psionic skill." To be fair it is also true that "Psionic Skills" is used as a sub-section heading. Let me know if you want me to change the naming to "Psionic" instead.