Skip to content

add moveMarker and addTextMarker #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Spice-Z wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

add moveMarker and addTextMarker #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a18c5f
add moveMarker and addTextMarker
Spice-Z Oct 16, 2025
408a8af
label color
Spice-Z Oct 30, 2025
9fa903e
seiz
Spice-Z Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
365 changes: 365 additions & 0 deletions android/src/main/java/com/google/android/react/navsdk/MapViewController.java
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 41 additions & 0 deletions android/src/main/java/com/google/android/react/navsdk/NavViewModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,25 @@ public void addMarker(int viewId, ReadableMap markerOptionsMap, final Promise pr
});
}



@ReactMethod
public void moveMarker(int viewId, String markerId, ReadableMap newPosition, int duration,
final Promise promise) {
UiThreadUtil.runOnUiThread(
() -> {
if (mNavViewManager.getGoogleMap(viewId) != null) {
mNavViewManager
.getFragmentForViewId(viewId)
.getMapController()
.moveMarker(markerId, newPosition.toHashMap(), duration);
promise.resolve(true);
} else {
promise.reject("NO_MAP", "Map not found for viewId: " + viewId);
}
});
}

@ReactMethod
public void addPolyline(int viewId, ReadableMap polylineOptionsMap, final Promise promise) {
UiThreadUtil.runOnUiThread(
Expand Down Expand Up @@ -233,6 +252,28 @@ public void addGroundOverlay(int viewId, ReadableMap overlayOptionsMap, final Pr
});
}

@ReactMethod
public void addTextMarker(int viewId, ReadableMap textMarkerOptionsMap, final Promise promise) {
UiThreadUtil.runOnUiThread(
() -> {
if (mNavViewManager.getGoogleMap(viewId) == null) {
promise.reject(JsErrors.NO_MAP_ERROR_CODE, JsErrors.NO_MAP_ERROR_MESSAGE);
return;
}
Marker textMarker =
mNavViewManager
.getFragmentForViewId(viewId)
.getMapController()
.addTextMarker(textMarkerOptionsMap.toHashMap());

if (textMarker != null) {
promise.resolve(ObjectTranslationUtil.getMapFromMarker(textMarker));
} else {
promise.reject("TEXT_MARKER_ERROR", "Failed to create text marker");
}
});
}

@Override
public boolean canOverrideExistingModule() {
return true;
Expand Down
2 changes: 2 additions & 0 deletions ios/react-native-navigation-sdk/NavViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ typedef void (^OnArrayResult)(NSArray *_Nullable result);
- (void)addGroundOverlay:(NSDictionary *)overlayOptions result:(OnDictionaryResult)completionBlock;
- (void)addCircle:(NSDictionary *)circleOptions result:(OnDictionaryResult)completionBlock;
- (void)addMarker:(NSDictionary *)markerOptions result:(OnDictionaryResult)completionBlock;
- (void)addTextMarker:(NSDictionary *)textMarkerOptions result:(OnDictionaryResult)completionBlock;
- (void)moveMarker:(NSString *)markerId newPosition:(NSDictionary *)newPosition duration:(NSInteger)duration;
- (void)addPolygon:(NSDictionary *)polygonOptions result:(OnDictionaryResult)completionBlock;
- (void)addPolyline:(NSDictionary *)options result:(OnDictionaryResult)completionBlock;
- (GMSMapView *)mapView;
Expand Down
Loading