feat(online): server-side ordering, pagination, and load-more fix#2
Merged
Spieler1ONE1 merged 1 commit intoSpieler1ONE1:mainfrom Mar 3, 2026
Conversation
- API: orderBy (latest/oldest/like/download), hasNextPage, get_character_list returns (rows, has_next_page) - Scraper/workers: pagination-only fetch, ScraperWorker supports order_by and multi-page - Online tab: sort matches website (trust API order for server-side sorts; refetch on sort change) - Load more: keep button when API has next page; track last_fetched_api_page so correct page is requested - Roulette: 5 random from API, refetch on GIRAR DE NUEVO - Add docs/API-INTEGRATION.md Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I am not a python developer so there are quite some things that I might have missed. The behaviour seems ok:
Description
Server-side ordering and pagination for the Online tab so the list matches the website and "Load more" works correctly.
orderBy(latest/oldest/like/download) andhasNextPage;get_character_listreturns(rows, has_next_page).ScraperWorkersupportsorder_byand multi-page initial load.last_fetched_api_pagetracks which page to request next so we don't re-request already-fetched pages.docs/API-INTEGRATION.mdfor API usage.Fixes the list appearing "stuck" after the first few pages and ensures sort order matches star-citizen-characters.com.
Type of change
Checklist
docs/API-INTEGRATION.md)