Refactor checkIdParam() & checkNameParam() to void functions
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkIdParam()andcheckNameParam()functions (in RequestUtil.php) check thatid/nameis present and valid in the request parameters. If not,exit()is called. Only if everything is correct istruereturned.This means that only true is returned anyway. So you don't need a return type or an if check when calling the functions.
This PR removes the redundant
return truefrom the functions and the if checks. PHPDoc also makes it clear that the functions callexit()independently if the necessary parameters are not present or are invalid.This PR helps me prepare for my next planned changes, such as adding a pagination.