Add json schema to core and make jsonschema dependency optional#326
Merged
samuelgarcia merged 1 commit intoSpikeInterface:mainfrom Mar 7, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 89.55% 89.55%
=======================================
Files 12 12
Lines 1944 1944
=======================================
Hits 1741 1741
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This replace #322 |
Contributor
I tried this out in https://src.fedoraproject.org/rpms/python-probeinterface/pull-request/5. It seems fine to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321
@musicinmybrain can you test this solution?
I moved the
probe.json.schemato the package directory and added it to be included in the wheel.In addition, the
jsonschemapackage is only imported when callingvalidate_probe_dict, so it should be safer.Let me know what you think!