Skip to content

Add json schema to core and make jsonschema dependency optional#326

Merged
samuelgarcia merged 1 commit intoSpikeInterface:mainfrom
alejoe91:json-schema-location
Mar 7, 2025
Merged

Add json schema to core and make jsonschema dependency optional#326
samuelgarcia merged 1 commit intoSpikeInterface:mainfrom
alejoe91:json-schema-location

Conversation

@alejoe91
Copy link
Copy Markdown
Member

@alejoe91 alejoe91 commented Mar 7, 2025

Fixes #321

@musicinmybrain can you test this solution?

I moved the probe.json.schema to the package directory and added it to be included in the wheel.
In addition, the jsonschema package is only imported when calling validate_probe_dict, so it should be safer.

Let me know what you think!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (5e45e90) to head (0d9a3ad).
Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files          12       12           
  Lines        1944     1944           
=======================================
  Hits         1741     1741           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuelgarcia
Copy link
Copy Markdown
Member

This replace #322
Thank ALessio.

@samuelgarcia samuelgarcia merged commit 32b9c85 into SpikeInterface:main Mar 7, 2025
5 checks passed
@musicinmybrain
Copy link
Copy Markdown
Contributor

@musicinmybrain can you test this solution?

I tried this out in https://src.fedoraproject.org/rpms/python-probeinterface/pull-request/5. It seems fine to me. Thanks!

@alejoe91 alejoe91 deleted the json-schema-location branch March 20, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The probeinterface.testing module loads probe.json.schema, which doesn’t ship with the wheel

3 participants