faster write_binary_recording() #4171
Open
+18
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
write_binary_recording()was using the memmap machinery but this is a bad idea for writing because it synchronize the buffer with the disk before writing with a read and this make it more slow.Of some system with netowrk drive this PR make the writing to binary 2 times faster witth this simple PR.
@h-mayorquin : I did also some test on the reading side, but there is no effect on perf so for now I keep memmap machinery on reading side. But maybe we could switch to this also in binary extarctor : simple seek and np.fromfile