Sequential curation #4298
Open
Sequential curation #4298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
And so I lost the debate... |
| elif operator == "median": | ||
| arr = np.median(wfs, axis=0) | ||
| elif "percentile" in operator: | ||
| _, percentile = operator.splot("_") |
| tmp_data["templates_multi"] = templates_multi | ||
| tmp_data["channel_locations_multi"] = channel_locations_multi | ||
| tmp_data["depth_direction"] = self.params["depth_direction"] | ||
| tmp_data["depth_direction"] = self.params.get("depth_direction") |
Member
There was a problem hiding this comment.
This was giving a bug when loading analyzers from old versions of si
Member
There was a problem hiding this comment.
lets pur a comment in the code the why of the get()
Member
There was a problem hiding this comment.
Was for backwards compatibility - now moved a fix to the _handle_backward_compatibility_on_load function, so it makes more sense why it happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4296
Extends curation to a
SequentialCuration, which contains a list ofCurationModelsteps that are applied in sequence