Bump mill to version 1.0.6 #1862

inochisa · 2025-12-25T07:33:47Z

Closes #1803

Context, Motivation & Description

Since the mill is bump to 1.0.0 release version, I think it is a good time point to bump the mill version.

Impact on code generation

I am not sure, but I think this PR should have no impact on code generation

Checklist

Unit tests were added
API changes are or will be documented:
- using Scaladoc comments: /** */?
- on RTD?
- thanks to a new tracking issue on RTD?

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

Dolu1990 · 2026-01-04T09:57:59Z

@Readon @KireinaHoro
Any objection ?
If i remember well, this could break the SpinalHDL integration from source in peoples mill project ? (big mill API change)

Readon · 2026-01-04T10:05:31Z

if i remember right, it would. we need to take more time to have it tested.

…

---Original--- From: ***@***.***> Date: Sun, Jan 4, 2026 17:58 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [SpinalHDL/SpinalHDL] Bump mill to version 1.0.6 (PR #1862) Dolu1990 left a comment (SpinalHDL/SpinalHDL#1862) @Readon @KireinaHoro Any objection ? If i remember well, this could break the SpinalHDL integration from source in peoples mill project ? (big mill API change) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

KireinaHoro · 2026-01-04T14:37:20Z

Yes -- @inochisa can you please check if we would still be able to include SpinalHDL as a submodule? Ideally the bumped version should still allow using it like in this project, sorry that I don't have time to give you a more stripped-down version...

KireinaHoro · 2026-01-04T21:37:20Z

Thanks -- @inochisa can you check to make sure that the workflow of using SpinalHDL as a git submodule would still work? Sorry I don't have a cut-down example at the moment, a big example would be in this project.

inochisa · 2026-01-05T02:46:34Z

@KireinaHoro I guess it is broken at least for now. I got the following error

[build.mill-48] generatedScriptSources Package declaration "package build.project" in ext/SpinalHDL/project/package.mill does not match folder structure. Expected: "package build.ext.SpinalHDL.project"
Package declaration "package build" in ext/SpinalHDL/package.mill does not match folder structure. Expected: "package build.ext.SpinalHDL"
Package declaration "package build.project" in ext/SpinalHDL/project/Version.mill does not match folder structure. Expected: "package build.ext.SpinalHDL.project"
Package declaration "package build.project" in ext/SpinalHDL/project/package.mill does not match folder structure. Expected: "package build.ext.SpinalHDL.project"
Package declaration "package build" in ext/SpinalHDL/build.mill does not match folder structure. Expected: "package build.ext.SpinalHDL"
Package declaration "package build" in ext/SpinalHDL/package.mill does not match folder structure. Expected: "package build.ext.SpinalHDL"

It seems like this is mentioned in com-lihaoyi/mill#5091, as you have known before.
But I have failed to overcome this by get rid of the code mentioned in this issue.

KireinaHoro · 2026-01-05T05:54:32Z

@inochisa thanks for the check! So my idea when I opened the issue was that, I’ll have some time to downgrade the error as mill upstream suggested, and then do the version bump on our side. Unfortunately I just didn’t get the time.

Would you have the interest to tinker with mill a bit? IIRC the change should be small, just disabling a check. Thanks and happy new year!

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

inochisa · 2026-01-09T05:47:39Z

@KireinaHoro At least for now, with PR com-lihaoyi/mill#6504, I have managed to compile my code with SpinalHDL repository.

You can check https://github.com/project-inochi/misc-ips/tree/mill-subproject for reference

KireinaHoro · 2026-01-09T09:33:50Z

@KireinaHoro At least for now, with PR com-lihaoyi/mill#6504, I have managed to compile my code with SpinalHDL repository.

You can check https://github.com/project-inochi/misc-ips/tree/mill-subproject for reference

Thanks! I really like the simplicity of the syntax and structure. I haven't attempted to build locally just yet, since the mill PR is not merged yet. I'll test locally as soon as that one is merged upstream.

Copilot

Pull request overview

This PR upgrades Mill build tool from version 0.11.6 to 1.0.6, migrating the build configuration from the legacy build.sc format to the new build.mill format introduced in Mill 1.0.x. The migration includes updating API usage to match Mill 1.0.x conventions.

Changes:

Upgraded Mill version from 0.11.6 to 1.0.6
Migrated build configuration from build.sc to build.mill with Mill 1.0.x API updates
Added package declarations to project files for better modularity

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
.mill-version	Updated Mill version from 0.11.6 to 1.0.6
build.sc	Removed legacy build.sc file (replaced by build.mill)
build.mill	New build configuration with Mill 1.0.x API (ivy→mvn, T→Task, Agg→Seq, ModuleRef removal)
project/package.mill	Added package declaration for build.project package
project/Version.mill	Added package declaration and updated to work with new build.mill structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T15:47:02Z

build.mill

+  val MvnDeps = Seq(
+    mvn"org.scala-lang:scala-library:${scalaVersion}",
+    mvn"org.scalactic:scalactic::3.2.10",
+    mvn"net.java.dev.jna:jna:5.12.1",
+    mvn"net.java.dev.jna:jna-platform:5.12.1",
+    mvn"org.slf4j:slf4j-api:2.0.5",
+    mvn"org.scala-lang.modules::scala-xml:1.3.0"
+  )


The variable MvnDeps is defined but never used. This appears to be a bug in the migration from Mill 0.11.x to 1.0.x. In the original code, IvyDeps was defined but individual modules called super.ivyDeps() which would inherit dependencies from the SbtModule trait.

With Mill 1.0.x, you need to override def mvnDeps in the SpinalModule trait to return these base dependencies. Change this from val MvnDeps = Seq(...) to def mvnDeps = super.mvnDeps() ++ Seq(...) so that child modules can properly inherit and extend these base dependencies.

Copilot · 2026-01-21T15:47:02Z

build.mill

+  def defaultCrossSegments = Seq(SpinalVersion.compilers.head)
+}
+trait Tester extends SpinalModule with SpinalPublishModule {
+  import moduleRefs._


The original Tester trait in build.sc included override def millSourcePath = os.pwd / "tester" which is missing in the migrated code. This override is important if the tester module's source path differs from the default convention. Without this override, Mill may not be able to locate the tester module's source files correctly.

Suggested change

import moduleRefs._

import moduleRefs._

override def millSourcePath = os.pwd / "tester"

inochisa added 14 commits December 25, 2025 14:31

mill: switch ivy dependency to mvn dependency

994c51b

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: adapt the task update

b691e02

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: remove usage of ModuleRef

c47529e

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill switch Agg group to native Seq

78d5166

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: adapt the renane of CrossSbtModuleTests

821d523

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: change the suffix of the build script from .sc to .mill

3610e5a

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: fix missing T replacement

15b73ef

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill fix build warning for args

984029e

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: fix version detected logic

b0d6777

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: rename millSourcePath to moduleDir

b6576a2

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: fix testOnly command

b0671c3

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: fix module depenedency

9af78ec

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: fix Tester module build

7d9f395

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: bump version to 1.0.6

2715072

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

mill: add test module to the SpinalModuleRef

f3791b8

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

inochisa force-pushed the mill-1.0 branch from 342addd to f3791b8 Compare January 9, 2026 01:06

Readon requested a review from Copilot January 21, 2026 15:42

Copilot started reviewing on behalf of Readon January 21, 2026 15:43 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bump mill to version 1.0.6 #1862

Bump mill to version 1.0.6 #1862

Uh oh!

inochisa commented Dec 25, 2025 •

edited

Loading

Uh oh!

Dolu1990 commented Jan 4, 2026

Uh oh!

Readon commented Jan 4, 2026 via email

Uh oh!

KireinaHoro commented Jan 4, 2026

Uh oh!

KireinaHoro commented Jan 4, 2026

Uh oh!

inochisa commented Jan 5, 2026 •

edited

Loading

Uh oh!

KireinaHoro commented Jan 5, 2026

Uh oh!

inochisa commented Jan 9, 2026

Uh oh!

KireinaHoro commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 21, 2026

Uh oh!

Copilot AI Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	import moduleRefs._
	import moduleRefs._
	override def millSourcePath = os.pwd / "tester"

Uh oh!

Bump mill to version 1.0.6 #1862

Are you sure you want to change the base?

Bump mill to version 1.0.6 #1862

Uh oh!

Conversation

inochisa commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context, Motivation & Description

Impact on code generation

Checklist

Uh oh!

Dolu1990 commented Jan 4, 2026

Uh oh!

Readon commented Jan 4, 2026 via email

Uh oh!

KireinaHoro commented Jan 4, 2026

Uh oh!

KireinaHoro commented Jan 4, 2026

Uh oh!

inochisa commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KireinaHoro commented Jan 5, 2026

Uh oh!

inochisa commented Jan 9, 2026

Uh oh!

KireinaHoro commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

inochisa commented Dec 25, 2025 •

edited

Loading

inochisa commented Jan 5, 2026 •

edited

Loading