Skip to content

Conversation

@alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Oct 20, 2025

This PR migrates the part of the GenerateProtoTask setup to extension functions used by GeneratedSourcePlugin. We do this to avoid the duplicated code used for building Base and ToolBase and by production code of the Compiler.

Notable changes

  • The Project.protocOutputDir was moved into Paths.kt and made internal so that Extension can use it instead of the removed Project.generatedSourceDir extension value.
  • The Plugin class now implements GeneratedDirectoryContext so that it can pass itself to GenerateProtoTask.configureSourceSetDirs() from ToolBase.

Copilot AI review requested due to automatic review settings October 20, 2025 19:39
@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the GenerateProtoTask configuration to use extension functions from GeneratedSourcePlugin to eliminate code duplication between building Base, ToolBase, and production compiler code.

  • Implements GeneratedDirectoryContext interface in the Plugin class
  • Removes local implementation of configureSourceSetDirs in favor of shared version from protobuf-setup-plugins
  • Updates dependencies from version 364 to 365 for spine tool-base modules

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
version.gradle.kts Bumped compiler version from 027 to 028
pom.xml Updated compiler and spine.tools dependency versions
Plugin.kt Implements GeneratedDirectoryContext, adds context receivers, removes duplicate code
Paths.kt Extracted protocOutputDir property as internal extension
Extension.kt Updated documentation reference from deprecated property to protocOutputDir
ConfigureIdea.kt Removed duplicate protocOutputDir property, updated documentation reference
dependencies.md Regenerated dependency report with new timestamps and versions
config Updated subproject commit reference
ToolBase.kt Bumped version from 364 to 365

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexander-yevsyukov alexander-yevsyukov changed the title Migrate to internals of GeneratedSourcePlugin Migrate to GenerateProtoTask.configureSourceSetDirs() from ToolBase Oct 20, 2025
@alexander-yevsyukov alexander-yevsyukov merged commit fe628f9 into master Oct 21, 2025
5 of 8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the migrate-to-generated-source-plugin-guts branch October 21, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants