Skip to content

Conversation

@alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Oct 29, 2025

This PR applies latest config and bumps ToolBase to the latest version from this PR. As the result we're having latest external dependencies, including latest Protobuf.

Copilot AI review requested due to automatic review settings October 29, 2025 20:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Protobuf to version 4.33.0 from 4.31.1, along with upgrading several related dependencies and build tools. The update requires restructuring imports for time-related functionality and adjusting build configurations to accommodate the new Protobuf version.

Key changes:

  • Upgraded Protobuf from 4.31.1 to 4.33.0
  • Updated multiple Spine dependencies (CoreJvm, Base, Time, ToolBase, etc.)
  • Migrated time extension imports from io.spine.time.toInstant to io.spine.time.java.toInstant
  • Added temporary Protobuf version compatibility check disabling in Gradle wrapper scripts
  • Removed deprecated build files and utilities

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
buildSrc/src/main/kotlin/io/spine/dependency/lib/Protobuf.kt Updates Protobuf version to 4.33.0
buildSrc/src/main/kotlin/io/spine/dependency/lib/Grpc.kt Updates gRPC version to 1.76.0
buildSrc/src/main/kotlin/io/spine/dependency/lib/Guava.kt Updates Guava version to 33.5.0-jre
buildSrc/src/main/kotlin/io/spine/dependency/local/Time.kt Adds new Java and Kotlin extension artifacts for Time library
test-env/src/main/kotlin/io/spine/tools/compiler/test/EchoRenderer.kt Updates import path for toInstant extension function
jvm/src/main/kotlin/io/spine/tools/compiler/jvm/annotation/ModifiedTypeAnnotation.kt Updates import path for toInstant extension function
cli/src/test/kotlin/io/spine/tools/compiler/cli/app/MainSpec.kt Updates import path for toInstant extension function
gradlew / gradlew.bat Temporarily disables Protobuf version compatibility checks
buildSrc/src/main/kotlin/io/spine/dependency/test/JUnit.kt Updates JUnit version to 6.0.0 and removes deprecated APIs
buildSrc/src/main/kotlin/BuildExtensions.kt Adds ProtoData task dependencies and duplication handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov changed the title Update Protobuf Update ToolBase and config Oct 29, 2025
@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 29, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review October 29, 2025 20:33
@alexander-yevsyukov alexander-yevsyukov requested review from armiol and Copilot and removed request for Copilot October 29, 2025 20:33
Copilot AI review requested due to automatic review settings October 29, 2025 20:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 36 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 23:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"The dependency `${this::class.simpleName}` does not declare a module `$module`."
)
} else {
"$module:$version"
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function now accepts an optional version parameter but doesn't validate the module parameter when a custom version is provided. When version is non-empty, it should still verify that the module is valid before constructing the artifact string. Consider: artifacts.containsKey(module) || error(...) before line 74.

Suggested change
"$module:$version"
if (!artifacts.containsKey(module)) {
error("The dependency `${this::class.simpleName}` does not declare a module `$module`.")
}
"$module:$version"

Copilot uses AI. Check for mistakes.
@alexander-yevsyukov alexander-yevsyukov merged commit c3dee2e into master Oct 30, 2025
6 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the update-protobuf-etc branch October 30, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants