-
Notifications
You must be signed in to change notification settings - Fork 0
Restore Policy as a deprecated class
#49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... because a `typealias` is not visible at the class level in JVM.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
armiol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-yevsyukov see my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR restores backward compatibility during the migration from Policy to Reaction by reintroducing the Policy class as a deprecated wrapper. The changes include a version bump to 2.0.0-SNAPSHOT.033, documentation improvements in the Reaction class, and build script refactoring.
- Adds deprecated
Policyclass that extendsReactionwith proper deprecation annotation and replacement guidance - Improves documentation clarity in
Reactionclass by making wording more concise and direct - Refactors build configuration to consolidate GitHub Pages publishing setup
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Version bump from 2.0.0-SNAPSHOT.032 to 2.0.0-SNAPSHOT.033 |
| pom.xml | Version bump to match gradle version |
| dependencies.md | Auto-generated dependency report with updated version references and timestamp |
| buildSrc/src/main/kotlin/module.gradle.kts | Removes unused CoreJava import, adds setupDocPublishing function for GitHub Pages configuration |
| api/src/main/kotlin/io/spine/tools/compiler/plugin/Reaction.kt | Minor documentation improvements for clarity and conciseness |
| api/src/main/kotlin/io/spine/tools/compiler/plugin/Policy.kt | New file - restores Policy class as deprecated wrapper of Reaction for backward compatibility |
| api-tests/build.gradle.kts | Removes module plugin as it's unnecessary for test-only module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR restores the
Policyclass which is derived fromReactionand deprecated in favour ofReaction. This is needed to provide backward compatibility during the migration process.Other notable changes