-
Notifications
You must be signed in to change notification settings - Fork 0
Add dependency between KSP and LaunchSpineCompiler tasks
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds dependency relationships between KSP (Kotlin Symbol Processing) tasks and LaunchSpineCompiler tasks to ensure proper task execution order. It also updates various library versions to avoid deprecations in generated code.
- Introduces
KspTaskNameclass to identify KSP tasks for different source sets - Updates dependency versions for Validation, CoreJvm, Time, and other local dependencies
- Corrects repository reference in GitHub workflow
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gradle-plugin/src/main/kotlin/io/spine/tools/compiler/gradle/plugin/LaunchSpineCompiler.kt | Adds KSP task dependency to ensure proper task ordering |
| gradle-plugin/src/main/kotlin/io/spine/tools/compiler/gradle/plugin/KspTaskName.kt | New class to generate KSP task names for source sets |
| buildSrc/src/main/kotlin/BuildExtensions.kt | Adds explicit dependency between test KSP task and compiler task |
| version.gradle.kts | Bumps compiler version from 037 to 038 |
| pom.xml | Updates versions for spine-server, validation, time, and other dependencies |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt | Updates version and adds deprecated oldRuntime constant |
| buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvm.kt | Updates CoreJvm version from 370 to 371 |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Time.kt | Updates Time version from 230 to 231 |
| buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt | Updates CoreJvmCompiler versions from 042 to 050 |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Compiler.kt | Updates fallback compiler versions from 036 to 037 |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Change.kt | Updates Change version from 205 to 206 |
| buildSrc/src/main/kotlin/io/spine/dependency/local/BaseTypes.kt | Updates BaseTypes version from 222 to 223 |
| .github/workflows/publish.yml | Corrects example repository name in comment |
| dependencies.md | Auto-generated dependency report with updated versions and timestamp |
| config | Updates subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gradle-plugin/src/main/kotlin/io/spine/tools/compiler/gradle/plugin/KspTaskName.kt
Show resolved
Hide resolved
LanuchSpineCompiler tasksLaunchSpineCompiler tasks
This PR updates the Compiler Gradle Plugin so that it creates dependencies between KSP and
LanuchSpineCompilertasks.Also, the PR updates the version of Validation to avoid the deprecations in the generated code. Other local dependencies were updated too.