-
Notifications
You must be signed in to change notification settings - Fork 0
Fix dependencies of the plugin-bundle module
#70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexander-yevsyukov
merged 8 commits into
master
from
fix-dependency-on-compiler-gradle-api
Feb 12, 2026
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1155636
Bump version -> `2.0.0-SNAPSHOT.052`
alexander-yevsyukov 1ef1943
Apply Gradle plugins via their classes
alexander-yevsyukov f81032c
Apply Gradle plugins via their classes
alexander-yevsyukov 675e710
Add missing dependencies to the plugin bundle artifact
alexander-yevsyukov 0e77962
Update dependency reports
alexander-yevsyukov 5389311
Fix missing import
alexander-yevsyukov 366d9c9
Document adding Protobuf Java Util library
alexander-yevsyukov e68c196
Update build time
alexander-yevsyukov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applyProtobufPlugin()applies Protobuf by class (apply<ProtobufPlugin>()) but the surrounding logic still relies on plugin ID checks/callbacks (hasPlugin(ProtobufGradlePlugin.id)here, andwithPlugin(ProtobufGradlePlugin.id)inapply). When a plugin is applied by type, Gradle does not reliably associate it with an ID, so the ID-based check/callback may not observe the plugin andapplyCoreJvmPlugins()may never run when Protobuf wasn’t already applied by ID. Prefer class-based checks/hooks (e.g.,plugins.hasPlugin(ProtobufPlugin::class.java)/plugins.withType(ProtobufPlugin::class.java)) or apply CoreJvm plugins immediately after applying Protobuf.