-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate to the Compiler API #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need to bring the new Compiler API to CoreJvm Compiler AND over the execution under McJava, because it's based on ProtoData.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Validation project from ProtoData to the new Spine Compiler API. The migration involves updating imports across all modules, replacing ProtoData references with Compiler references, and temporarily removing java-tests modules due to API incompatibility during the transition.
Key changes include:
- Global import changes from
io.spine.protodata.*toio.spine.tools.compiler.* - Build configuration updates to use the new Compiler plugin instead of ProtoData
- Version updates and dependency substitutions
Reviewed Changes
Copilot reviewed 187 out of 194 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps version from 2.0.0-SNAPSHOT.342 to 2.0.0-SNAPSHOT.350 |
| settings.gradle.kts | Comments out java-tests modules during migration |
| proto/**.proto | Updates imports from spine/protodata to spine/compiler |
| model/src/main/kotlin/** | Updates imports and class references to use Compiler API |
| java/src/main/kotlin/** | Updates imports and class references to use Compiler API |
| build files | Updates dependency and plugin references from ProtoData to Compiler |
Files not reviewed (2)
- .idea/dictionaries/common.xml: Language not supported
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 187 out of 194 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- .idea/dictionaries/common.xml: Language not supported
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
Comments suppressed due to low confidence (1)
proto/context/src/main/proto/spine/validation/views.proto:1
- There's a trailing backtick character at the end of the comment line that should be removed.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
============================================
- Coverage 33.47% 28.11% -5.36%
+ Complexity 279 201 -78
============================================
Files 136 129 -7
Lines 3226 3126 -100
Branches 249 246 -3
============================================
- Hits 1080 879 -201
- Misses 2072 2178 +106
+ Partials 74 69 -5 🚀 New features to boost your workflow:
|
This PR introduces interim version of Validation built for this PR of CoreJvm Compiler.
This PR temporarily removes the
java-testsmodules that cannot run because of the interim API incompatibilities related to the migration to new API structure. The tests will be restored when we have a working version of the CoreJvm Compiler, which can be applied to Validation.Other notable changes
configwas updated.