Skip to content

Conversation

@alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Sep 21, 2025

This PR introduces interim version of Validation built for this PR of CoreJvm Compiler.

This PR temporarily removes the java-tests modules that cannot run because of the interim API incompatibilities related to the migration to new API structure. The tests will be restored when we have a working version of the CoreJvm Compiler, which can be applied to Validation.

Other notable changes

  • config was updated.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 21, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 23, 2025 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Validation project from ProtoData to the new Spine Compiler API. The migration involves updating imports across all modules, replacing ProtoData references with Compiler references, and temporarily removing java-tests modules due to API incompatibility during the transition.

Key changes include:

  • Global import changes from io.spine.protodata.* to io.spine.tools.compiler.*
  • Build configuration updates to use the new Compiler plugin instead of ProtoData
  • Version updates and dependency substitutions

Reviewed Changes

Copilot reviewed 187 out of 194 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
version.gradle.kts Bumps version from 2.0.0-SNAPSHOT.342 to 2.0.0-SNAPSHOT.350
settings.gradle.kts Comments out java-tests modules during migration
proto/**.proto Updates imports from spine/protodata to spine/compiler
model/src/main/kotlin/** Updates imports and class references to use Compiler API
java/src/main/kotlin/** Updates imports and class references to use Compiler API
build files Updates dependency and plugin references from ProtoData to Compiler
Files not reviewed (2)
  • .idea/dictionaries/common.xml: Language not supported
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 24, 2025 16:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 187 out of 194 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • .idea/dictionaries/common.xml: Language not supported
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported
Comments suppressed due to low confidence (1)

proto/context/src/main/proto/spine/validation/views.proto:1

  • There's a trailing backtick character at the end of the comment line that should be removed.
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexander-yevsyukov alexander-yevsyukov merged commit 7fd99ec into master Sep 24, 2025
7 checks passed
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.11%. Comparing base (7ad0eeb) to head (750b564).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     33.47%   28.11%   -5.36%     
+ Complexity      279      201      -78     
============================================
  Files           136      129       -7     
  Lines          3226     3126     -100     
  Branches        249      246       -3     
============================================
- Hits           1080      879     -201     
- Misses         2072     2178     +106     
+ Partials         74       69       -5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov deleted the migrate-to-compiler branch September 24, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants