-
Notifications
You must be signed in to change notification settings - Fork 0
Update Gradle and other dependencies #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also: * Convert `NumberConversion` to Kotlin.
As we've applied the workaround from jk1/Gradle-License-Report#337, nested parent projects may not have report files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Gradle and various project dependencies to their latest versions. The update includes Gradle version bump, Kotlin version update, and multiple Spine framework library updates.
Key changes:
- Gradle upgraded from 8.14.2 to 9.1.0
- Kotlin upgraded from 2.1.21 to 2.2.20
- Updated various Spine framework libraries (Base, CoreJvm, Compiler, etc.) to their latest snapshot versions
Reviewed Changes
Copilot reviewed 33 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to version 9.1.0 |
| pom.xml | Updates dependency versions for Kotlin, Kotest, and Spine libraries |
| version.gradle.kts | Bumps validation version from SNAPSHOT.352 to SNAPSHOT.353 |
| buildSrc/src/main/kotlin/io/spine/dependency/*.kt | Updates version constants for various dependencies |
| java-runtime/src/main/kotlin/io/spine/validate/NumberConversion.kt | Adds new Kotlin implementation to replace Java version |
| java-runtime/src/main/java/io/spine/validate/NumberConversion.java | Removes Java implementation |
| proto/*/build.gradle.kts | Adds task dependency configuration for Spine compiler |
| buildSrc/src/main/kotlin/io/spine/gradle/publish/ShadowJarExts.kt | Changes service file merging strategy |
| buildSrc/build.gradle.kts | Updates Shadow plugin and License Report plugin versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
============================================
+ Coverage 34.12% 34.47% +0.34%
Complexity 282 282
============================================
Files 136 136
Lines 3226 3231 +5
Branches 249 247 -2
============================================
+ Hits 1101 1114 +13
+ Misses 2048 2040 -8
Partials 77 77 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 33 out of 36 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/LicenseReporter.kt
Outdated
Show resolved
Hide resolved
armiol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for two minor comments.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 33 out of 36 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR updates the version of Gradle to 9.1.0, applying the workaround for the issue with License Report. The workaround is in disabling
generateLicenseReporttasks in build filesjava-tests/build.gradle.ktsandproto/build.gradle.kts.protoandjava-testsare interim parent Gradle projects, which causes the problem with the configuration resolution under Gradlel 9.0.0 and on.Other notable changes
configwas applied brining new versions of local and external dependencies.NumberConversionwas converted to Kotlin to address the warning of exposing package-access API.