-
Notifications
You must be signed in to change notification settings - Fork 0
Add implementation dependency for Java runtime; put Java Plugin first
#248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Validation Gradle Plugin to automatically add the implementation dependency for the Java runtime module (spine-validation-jvm-runtime) to projects where the plugin is applied. Additionally, it configures the Spine Compiler to prioritize the JavaValidationPlugin as the first plugin in the execution pipeline, ensuring validation code is generated before other plugins that may depend on it.
Key changes:
- Automatic addition of
implementationdependency for validation runtime - Prioritization of Java Validation Plugin in compiler execution order
- Refactoring of
ValidationSdkto use properties instead of versioned functions
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Version bump to 2.0.0-SNAPSHOT.375 |
| pom.xml | Version bump to 2.0.0-SNAPSHOT.375 |
| java-bundle/build.gradle.kts | Improved exclusion logic for Compiler module dependencies |
| gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationSdk.kt | Refactored to expose properties instead of versioned functions |
| gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationGradlePlugin.kt | Added implementation dependency and plugin ordering logic |
| gradle-plugin/build.gradle.kts | Updated to use versioned dependency functions |
| dependencies.md | Auto-generated dependency report updates |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt | Added versioned function for runtime dependency |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Compiler.kt | Implemented Dependency interface with modules list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationGradlePlugin.kt
Show resolved
Hide resolved
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationGradlePlugin.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationGradlePlugin.kt
Show resolved
Hide resolved
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationGradlePlugin.kt
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
============================================
- Coverage 34.83% 34.82% -0.02%
Complexity 288 288
============================================
Files 141 141
Lines 3103 3104 +1
Branches 246 249 +3
============================================
Hits 1081 1081
- Misses 1943 1944 +1
Partials 79 79 🚀 New features to boost your workflow:
|
This PR makes the
ValidationGradlePluginto applyimplementationdependency for a project to which the plugin is applied.Also now the plugin configures the Spine Compiler to run
JavaValidationPluginto run first in the pipeline. Validation is a core feature on which other plugins may rely in the generated code.Other notable changes
java-bundlemodule.