Skip to content

Conversation

@alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Dec 15, 2025

This PR makes the ValidationGradlePlugin to apply implementation dependency for a project to which the plugin is applied.

Also now the plugin configures the Spine Compiler to run JavaValidationPlugin to run first in the pipeline. Validation is a core feature on which other plugins may rely in the generated code.

Other notable changes

  • The PR also fixes the exclusion of the Compiler modules in the fat JAR produced by the java-bundle module.

Copilot AI review requested due to automatic review settings December 15, 2025 18:47
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review December 15, 2025 18:47
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Validation Gradle Plugin to automatically add the implementation dependency for the Java runtime module (spine-validation-jvm-runtime) to projects where the plugin is applied. Additionally, it configures the Spine Compiler to prioritize the JavaValidationPlugin as the first plugin in the execution pipeline, ensuring validation code is generated before other plugins that may depend on it.

Key changes:

  • Automatic addition of implementation dependency for validation runtime
  • Prioritization of Java Validation Plugin in compiler execution order
  • Refactoring of ValidationSdk to use properties instead of versioned functions

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
version.gradle.kts Version bump to 2.0.0-SNAPSHOT.375
pom.xml Version bump to 2.0.0-SNAPSHOT.375
java-bundle/build.gradle.kts Improved exclusion logic for Compiler module dependencies
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationSdk.kt Refactored to expose properties instead of versioned functions
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationGradlePlugin.kt Added implementation dependency and plugin ordering logic
gradle-plugin/build.gradle.kts Updated to use versioned dependency functions
dependencies.md Auto-generated dependency report updates
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt Added versioned function for runtime dependency
buildSrc/src/main/kotlin/io/spine/dependency/local/Compiler.kt Implemented Dependency interface with modules list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov merged commit c5dc47d into master Dec 15, 2025
6 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the add-impl-dependency branch December 15, 2025 19:05
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.82%. Comparing base (6bca167) to head (1ecafe1).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
- Coverage     34.83%   34.82%   -0.02%     
  Complexity      288      288              
============================================
  Files           141      141              
  Lines          3103     3104       +1     
  Branches        246      249       +3     
============================================
  Hits           1081     1081              
- Misses         1943     1944       +1     
  Partials         79       79              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants