Rename io.spine.validate to io.spine.validation
#253
Conversation
Also: * Provide backward compatibility interfaces.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
============================================
- Coverage 34.99% 34.92% -0.07%
Complexity 276 276
============================================
Files 137 137
Lines 3049 3055 +6
Branches 244 244
============================================
Hits 1067 1067
- Misses 1908 1914 +6
Partials 74 74 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR renames the io.spine.validate package to io.spine.validation to address issue #252. The changes update import statements and package declarations across the codebase, while maintaining backward compatibility through deprecated wrapper interfaces in the old package.
Key Changes:
- Package renamed from
io.spine.validatetoio.spine.validationthroughout the codebase - Deprecated wrapper interfaces added in the old package to maintain backward compatibility during transition
- Version bumped from
2.0.0-SNAPSHOT.378to2.0.0-SNAPSHOT.380
Reviewed changes
Copilot reviewed 168 out of 168 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Updated validation version to 2.0.0-SNAPSHOT.380 |
| jvm-runtime/src/main/proto/spine/validate/*.proto | Updated java_package option to io.spine.validation |
| jvm-runtime/src/main/java/io/spine/validation/*.java | New package location for validation runtime classes |
| jvm-runtime/src/main/java/io/spine/validate/*.java | Deprecated wrapper interfaces extending new package classes |
| Multiple test files | Updated imports from io.spine.validate to io.spine.validation |
| java/src/main/kotlin/**/*.kt | Updated imports and references to new validation package |
| pom.xml | Updated dependency coordinates and versions |
| dependencies.md | Generated timestamp updates reflecting new build |
Comments suppressed due to low confidence (1)
tests/validating/src/test/kotlin/io/spine/test/options/AssumedRequiredITest.kt:1
- Unused imports removed. These imports were used in the deleted test methods but are no longer needed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
java/src/main/kotlin/io/spine/tools/validation/java/generate/ValidationCodeInjector.kt
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Update placeholder extractor import to new package
The package rename to io.spine.validation removed extractPlaceholders from io.spine.validate, but this file still imports the old package. With no compatibility shim for that top-level function, the context module will fail to compile due to an unresolved reference; the import needs to point to io.spine.validation.extractPlaceholders instead.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 168 out of 168 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return validate(noParentPath, null); | ||
| } | ||
| @Deprecated | ||
| public interface ValidatableMessage extends io.spine.validation.ValidatableMessage { |
There was a problem hiding this comment.
ValidatableMessage has the same name as its supertype io.spine.validation.ValidatableMessage.
This PR addresses the #252 issue. The Validation Compiler was adjusted to use the new package at almost all occasions. In some places old interfaces have to be used during the transition process. The interfaces in the old package are now derived from the corresponding interfaces in the new package, and deprecated accordingly.
Other notable changes