-
Notifications
You must be signed in to change notification settings - Fork 0
Fix proto package name #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames the proto package from spine.validate to spine.validation and increments the version from 2.0.0-SNAPSHOT.381 to 2.0.0-SNAPSHOT.382.
- Updated proto package declarations from
spine.validatetospine.validationin proto files - Updated import paths to reflect the new package name
- Simplified type reference by removing redundant package prefix
- Incremented snapshot version to 382
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Incremented validation version from 381 to 382 |
| pom.xml | Updated version number to match the new snapshot |
| jvm-runtime/src/main/proto/spine/validation/validation_error.proto | Changed package declaration from spine.validate to spine.validation, updated import path, and simplified TemplateString type reference |
| jvm-runtime/src/main/proto/spine/validation/error_message.proto | Changed package declaration from spine.validate to spine.validation |
| dependencies.md | Auto-generated dependency report with updated version numbers and timestamps |
Comments suppressed due to low confidence (1)
jvm-runtime/src/main/proto/spine/validation/validation_error.proto:63
- The comment references the old Java package name
io.spine.validate. It should be updated toio.spine.validation.TemplateStrings.format()to match the package rename performed in this PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=========================================
Coverage 34.92% 34.92%
Complexity 276 276
=========================================
Files 137 137
Lines 3055 3055
Branches 244 244
=========================================
Hits 1067 1067
Misses 1914 1914
Partials 74 74 🚀 New features to boost your workflow:
|
This PR renames the proto package
spine.validatetospine.validation.