-
Notifications
You must be signed in to change notification settings - Fork 0
Avoid applying the module script plugin via submodules
#256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid applying the module script plugin via submodules
#256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR continues the migration to a new package structure by bumping the validation version from 2.0.0-SNAPSHOT.382 to 2.0.0-SNAPSHOT.383 and introducing forced dependency resolution for the new package name io.spine.validation:spine-validation-java-runtime.
Key Changes
- Version increment from SNAPSHOT.382 to SNAPSHOT.383 across all project artifacts
- Addition of forced dependency resolution for the migrated package
io.spine.validation:spine-validation-java-runtimeat version 2.0.0-SNAPSHOT.360 - Updated license report generation timestamps
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| version.gradle.kts | Increments the validation version to 2.0.0-SNAPSHOT.383 |
| pom.xml | Updates the project version to match the new snapshot version |
| dependencies.md | Reflects the version update in all module dependency headers and regenerates license reports with new timestamp |
| build.gradle.kts | Adds forced dependency resolution for the new package io.spine.validation:spine-validation-java-runtime:2.0.0-SNAPSHOT.360 in both buildscript and allprojects configuration blocks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage 34.92% 34.92%
Complexity 276 276
=========================================
Files 137 137
Lines 3055 3055
Branches 244 244
=========================================
Hits 1067 1067
Misses 1914 1914
Partials 74 74 🚀 New features to boost your workflow:
|
module script plugin via submodules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This PR updates the build scripts to avoid applying the script plugin
moduleviasubmodulesblock of the root project. This lead to making test-only modules trying to publish missing documentation to GitHub Pages. Now only modules mentioned inspinePublishingshould publish its documentation.