Skip to content

Conversation

@alexander-yevsyukov
Copy link
Collaborator

This PR updates the jvm-runtime module to avoid the dependency on Spine Logging. This is needed for the Validation to be used in a non-Spine project with minimal dependencies.

Other notable changes

  • The build migrates to latest CoreJvm Compiler and Validation so that generated code uses types from io.spine.validation.

Copilot AI review requested due to automatic review settings December 25, 2025 17:48
@alexander-yevsyukov alexander-yevsyukov self-assigned this Dec 25, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review December 25, 2025 17:49
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Spine Logging dependency from the jvm-runtime module to enable Validation to be used in non-Spine projects with minimal dependencies. The build also migrates to the latest CoreJvm Compiler (2.0.0-SNAPSHOT.050) and Validation (2.0.0-SNAPSHOT.390) versions.

  • Spine Logging dependency moved from compile scope to test scope in pom.xml
  • Logging framework calls replaced with System.err for warnings and errors
  • Version updates across multiple configuration files

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
version.gradle.kts Version bumped from 2.0.0-SNAPSHOT.390 to 2.0.0-SNAPSHOT.391
pom.xml Moved spine-logging from compile to test scope; updated various dependency versions
jvm-runtime/build.gradle.kts Removed Logging.lib implementation dependency
jvm-runtime/src/main/java/io/spine/validation/option/Required.java Removed WithLogging interface and replaced logger calls with System.err.printf
jvm-runtime/src/main/java/io/spine/validation/option/Goes.java Removed WithLogging interface and replaced logger calls with System.err.println
jvm-runtime/src/main/java/io/spine/validation/Validate.java Removed Logger imports and replaced logger calls with System.err.printf
jvm-runtime/src/main/java/io/spine/validation/FieldConstraints.java Removed Logger imports, converted switch statement to switch expression, and removed unreachable default case
jvm-runtime/src/main/kotlin/io/spine/validation/option/NonPrimitiveOptionFactory.kt Removed explicit generic type parameters from Sets.union call
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt Updated Validation version to 2.0.0-SNAPSHOT.390
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Updated CoreJvm Compiler versions to 2.0.0-SNAPSHOT.050
dependencies.md Auto-generated dependency report with updated timestamps and removed transitive dependencies (atomicfu, kotlinx-datetime)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 25, 2025 18:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov merged commit 056863f into master Dec 25, 2025
5 of 6 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the avoid-logging-dependency-in-runtime branch December 25, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants