Skip to content

Move ServiceLoader.iterator.hasNext call inside the try...catch in MixinService #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexIIL wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move ServiceLoader.iterator.hasNext call inside the try...catch in MixinService #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/spongepowered/asm/service/MixinService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,11 @@ private IMixinService initService() {
Iterator<IMixinService> iter = this.serviceLoader.iterator();
List<String> badServices = new ArrayList<String>();
int brokenServiceCount = 0;
while (iter.hasNext()) {
while (true) {
try {
if (!iter.hasNext()) {
break;
}
IMixinService service = iter.next();
if (this.bootedServices.contains(service.getClass().getName())) {
MixinService.logBuffer.debug("MixinService [{}] was successfully booted in {}", service.getName(),
Expand Down