Avoid recursion as much as possible when searching for a spawn#4258
Merged
Avoid recursion as much as possible when searching for a spawn#4258
Conversation
Fix MC-304426 and #4253
aromaa
approved these changes
Nov 29, 2025
Member
aromaa
left a comment
aromaa
left a comment
There was a problem hiding this comment.
LGTM, modulo the two comments.
While the Overwrite is a bit invasive, I don't think there is any other good alternative. We can always revisit if something comes up.
src/mixins/java/org/spongepowered/common/mixin/core/server/level/PlayerSpawnFinderMixin.java
Outdated
Show resolved
Hide resolved
src/mixins/java/org/spongepowered/common/mixin/core/server/level/PlayerSpawnFinderMixin.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MC-304426 and #4253.
I'm not sure if we want to avoid the overwrite here because there are some important control flow changes.