Skip to content

Conversation

@eladyn
Copy link
Member

@eladyn eladyn commented Mar 11, 2025

Fixes #1334.

This fixes the selection of the bindgen feature, such that on most platforms, it should automatically choose the correct behaviour.

@fallingcats
Copy link
Contributor

Wouldn't rust-version = "1.82" be insufficient for resolver = "3"?

https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions

@eladyn
Copy link
Member Author

eladyn commented Mar 11, 2025

Oh, you're right. Good catch.

@eladyn eladyn changed the title chore: use resolver v3 for correct bindgen feature chore: use resolver v2 for correct bindgen feature Mar 11, 2025
@fallingcats
Copy link
Contributor

fallingcats commented Mar 11, 2025

Btw you could use single quotes for the outer quotes of the 'cfg(...)' strings, if you like. The official docs do so as well.

@eladyn eladyn merged commit fa9de10 into Spotifyd:master Mar 11, 2025
6 checks passed
@eladyn eladyn deleted the resolver_v3 branch March 11, 2025 03:09
@eladyn
Copy link
Member Author

eladyn commented Mar 11, 2025

Thank you for your help resolving this! <3

@fallingcats
Copy link
Contributor

Thanks for doing the actual work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing dependencies for aws-lc-sys

2 participants