Fix changePlayerName mutation #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Sprocket member_profile table
gankoji
requested changes
Jan 2, 2026
Member
|
While we don't have a good setup for local testing that the mutation actually works, I do generally need to make sure that you don't break the build. Please at least run Yes, 16. I know. |
gankoji
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the PlayerService#changePlayerName function to additionally make changes to Sprocket's member_profile table. Previous code updated the name in the legacy mledb
playertable and Sprocket'suser_profiletable, but did not update the member_profile.Note: This change is untested. I don't have the time atm to dig into learning TS Repositories, not sure how the relation thing works tbh.