Remove wsqlite3-sys
#166
Merged
Remove wsqlite3-sys
#166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `rsqlite-vfs` no longer depends on `*-sys`, `wsqlite3-sys` has become irrelevant
Contributor
|
Thanks for taking care of this. I took a few days of from GitHub over the holidays. |
Owner
Author
|
I might release it in the next few days. Is there anything else I need to do？:) |
Contributor
|
No, it should be fine from my side |
Owner
Author
|
Contributor
|
For reference: I updated the diesel nostd PR (diesel-rs/diesel#4906) to use the new rsqlite-vfs crate and everything worked as expected 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
rsqlite-vfsno longer depends on*-sys,wsqlite3-syshas become irrelevantcc @weiznich