🐛 Fix VS Code not showing multi-line completions#1185
Draft
Conversation
SPGoding
force-pushed
the
multi-line-completion-fix
branch
3 times, most recently
from
ddc88a6 to
7d0ae87
Compare
SPGoding
force-pushed
the
multi-line-completion-fix
branch
from
902518c to
c629077
Compare
Member
Author
|
i wrote this at 5 am while i was frustrated with VS Code. need to double check everything. |
…lti-line-completion-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1180 (only changes are in 7d0ae87).
Fixes #1183.
multi-line-completion.mp4
Note that this workaround is only implemented for language clients that set
hasFlawedMultiLineCompletionItemFilteringtotruein the initialization options, since the original code in Afro's PR works fine for text editors with proper multi-line completion item filtering support (e.g. Helix) and although the workaround makes the completion items show up to the user, it does not do any filtering when the user is not on the first line of the multi-line range due to #1184.no-filtering-on-second-line.mp4