✨ Add completions for empty strings, structs, and lists#1359
Draft
misode wants to merge 1 commit intoSpyglassMC:mainfrom
Draft
✨ Add completions for empty strings, structs, and lists#1359misode wants to merge 1 commit intoSpyglassMC:mainfrom
misode wants to merge 1 commit intoSpyglassMC:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
not to be too annoying about it but either a test or a blurb/example in the PR description would be helpful for those of us not super familiar with the intention/feature/bug etc. in-action (me)
(although this is still draft so maybe that was coming later 😄 )
Member
Author
|
We don't have any tests for completions right now, but I can attach a screenshot, sure 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no specific values available, suggests an empty string/struct/list. Still a draft because there are some cases where it only gives one of the options when in reality both a struct and list are allowed. And sometimes it doesn't show any completions.