Skip to content

✨ Use vanilla required_level added in 25w20a#1809

Open
jacobsjo wants to merge 1 commit intoSpyglassMC:mainfrom
jacobsjo:use-vanilla-required_level
Open

✨ Use vanilla required_level added in 25w20a#1809
jacobsjo wants to merge 1 commit intoSpyglassMC:mainfrom
jacobsjo:use-vanilla-required_level

Conversation

@jacobsjo
Copy link
Contributor

  • Adjusts patches for old version to use the same format.

+ adjust patches for old version to use same format
@misode
Copy link
Member

misode commented May 13, 2025

Looking at the code here, I'm not a fan that getPatch doesn't end up returning the final correct patch, and that the it needs to be patched again after being merged with the raw commands dump.

I feel like a better solution would be to change our default in the patch to 0 as well and explicitly patch the 61 nodes that have required_level: 2 for backwards compatibility.

@misode
Copy link
Member

misode commented Oct 9, 2025

Since 25w41a, the generated data format changed:
image

Not sure how or even whether we should continue with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants