This repository was archived by the owner on Apr 25, 2025. It is now read-only.
simplify execute_tx re-entrancy check and remove crate dependency#42
Open
Arrowana wants to merge 2 commits intoSquads-Protocol:mainfrom
Open
simplify execute_tx re-entrancy check and remove crate dependency#42Arrowana wants to merge 2 commits intoSquads-Protocol:mainfrom
Arrowana wants to merge 2 commits intoSquads-Protocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same check but not allocating a vec, not converting from hex to Vec, single get, no hardcoding of magic numbers. Finally, i feel this is more readable.
Note: Let me know if i need to revert whitespace changes and minor rust formatting