Skip to content

Enhance LinearCameraEmbedder with Type Hints #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandlinsarah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance LinearCameraEmbedder with Type Hints #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sf3d/models/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from dataclasses import dataclass, field
from typing import List
from typing import List, Dict, Any

import torch
import torch.nn as nn
Expand All @@ -19,7 +19,7 @@ class Config(BaseModule.Config):
def configure(self) -> None:
self.linear = nn.Linear(self.cfg.in_channels, self.cfg.out_channels)

def forward(self, **kwargs):
def forward(self, **kwargs: Dict[str, torch.Tensor]) -> torch.Tensor:
cond_tensors = []
for cond_name in self.cfg.conditions:
assert cond_name in kwargs
Expand All @@ -30,3 +30,4 @@ def forward(self, **kwargs):
assert cond_tensor.shape[-1] == self.cfg.in_channels
embedding = self.linear(cond_tensor)
return embedding