Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the application, focusing on adding support for the multiple blockchain networks.
Blockchain Application Changes:
Environment Configuration:
BLOCKSCOUT_API_KEY,BLOCKSCOUT_HOMEPAGE_URL, andETHEREUM_MORDOR_RPC_URLto the.env.examplefile.Deployment Scripts:
Makefileto include a new targetdeploy-ethereum-mordorfor deploying contracts to the Ethereum Mordor testnet.DeployFairFund.s.solto handle different chain names and update the deployment JSON file accordingly.Web Application Changes:
Chain ID Support:
chainIdto theFundingVaultmodel in Prisma schema and updated the migration file to include this new column. [1] [2]chainIdfield, ensuring the correct chain ID is passed to the smart contract functions. (app/web-app/src/app/(root)/proposal/[id]/page.tsxR36, app/web-app/src/app/(root)/proposal/[id]/page.tsxR77, app/web-app/src/app/(root)/vault/[id]/results/page.tsxR142, app/web-app/src/app/(root)/vault/[id]/results/page.tsxR154, app/web-app/src/app/(root)/vault/deposit/page.tsxR29)UI Enhancements:
SpaceDetailsPageto display the chain name where the vault is deployed. (app/web-app/src/app/(root)/spaces/[id]/page.tsxR15, app/web-app/src/app/(root)/spaces/[id]/page.tsxR110-R111, app/web-app/src/app/(root)/spaces/[id]/page.tsxR120-R130)Completes #45